Update von Konstruktionen - SimpleProposal

Hab mich ja bei Track/Street Info schon damit beschäftigen müssen. Wobei lesen natürlich einfacher ist als schreiben.

Ich glaube aber es ist sinnvoll, sich die proposals vom Spiel anzuschauen. Dazu kann ich auf jeden Fall die CommonAPI mit dem Event Inspector empfehlen. Dann muss man sich nicht die stdout mit debugPrint vollschreiben

Wenn es um den Datentyp geht, kriegt man den Luatyp natürlich mit type(...)

Bei userdata sind es dann api types und den genauen TPF Type findet man über getmetatable raus. Das sieht man aber auch mit commonapi.dmp und im Inspector.

So wie ich die API Doku gelesen habe, müssen alle neuen Edges eindeutige Ids im Negativen Vorzeichen haben, überall -1 zu nehmen wird wohl nicht gehen.

old2new würde sagen, = { { alteEntityid, constructionsToAddIndex }}

constructionsToAddIndex kann ggf bei 0 anfangen, weil die C API das so will...

PS: Schön das ich anderen Moddern die Arbeit erleichtern kann, es wäre nett wenn das öfter Erwähnung findet, dann kann ich auch besser Prioritäten bei der Entwicklung setzen.

Ich habe auf meiner Todoliste ne Funktion für die CommonAPI2 um kurze Schienenstücke ohne Elektrifizierung zu finden. Aber dann kommt UG mit ner neuen Beta um die Ecke und dann hab ich erst mal wieder Zeit zum reparieren verbraten...

Links zur aktuellen Version mit Beta funktionierend (bis UG heute Abend wieder ne neue Beta herausbringt )

CommonAPI2 - Neue Versionen und wichtige Informationen

Der Event Inspector und commonapi.dmp funktionieren auch ohne nativen dll/so Teil.

Es muss commonapi im Savegame als Mod geladen sein, dann gibt es unten einen API Knopf mit neuen Menü.

At least you
can use game.interface.upgradeConstruction and game.interface.bulldoze which comes from tpf1 (and documented in tpf1
wiki)
For a removal example of Simple Proposal I did one in track design pattern mod. For modifying or creating, I think it's more or less the same to edges, you just create a similar proposal like what you see in the guievent

proposal.constructionsToAdd[1] = newConstr --?????????? this is the main problem!!

Have you tried

proposal.constructionsToAdd[#proposal.constructionsToAdd+1] = newConstr

Did some attempt and I succed to remove a station then bring it back via api.

There are some key things:

I retrived the old params by:

params = game.interface.getEntity(id).params

then create the construction proposal by

po = api.type.SimpleProposal.ConstructionEntity.new()

I need also copy the old tranfs by

co = api.engine.getComponent(id, api.type.ComponentType.CONSTRUCTION)
for i = 1, 16 do
 po.transf[i] = co.transf[i]
end

then create a simple proposal and make the cmd of it then send it

However, it seems the command is send directly to the updateFn of the construction so you need to change the module table to change things such as number of tracks etc..

I think the way above is too complicated comparing to game.interface, which you can do thing in the fly, the only drawback is you can call the game.interface functions only from engine loop not gui loop.

Zitat von WernerK

At last I have contacted UG and received an answer. This here is not the original code they gave me, but my own adaption - and - big surprise - it works! It should not be a secret, it is useful for all modders, so I publish it here:

Code

local entities = game.interface.getEntities({radius = 999999},{type = "CONSTRUCTION", includeData = false})
for _, constrId in pairs (entities) do
    local constr = api.engine.getComponent(constrId, api.type.ComponentType.CONSTRUCTION)
    if constr.fileName and string.find(constr.fileName, "wk_switch_kit") then -- only for my switch modules, you can also use other criteria
        local newConstr = api.type.SimpleProposal.ConstructionEntity.new()
        newConstr.fileName = constr.fileName
        newConstr.params = game.interface.getEntity(constrId).params
        for i = 1, 16 do
            newConstr.transf[i] = constr.transf[i]
        end
        if constr.name then
            newConstr.name = constr.name
        else
            newConstr.name = "no name"
        end
        newConstr.playerEntity = api.engine.util.getPlayer()
        newConstr.headquarters = false
        local proposal = api.type.SimpleProposal.new()
        proposal.old2new = {[constrId] = 0} -- 0! Not -1! What a surprise! :-)
        proposal.constructionsToRemove = {constrId}
        proposal.constructionsToAdd[1] = newConstr
        api.cmd.sendCommand(api.cmd.make.buildProposal(proposal, nil, false), function(res, success)
        --- insert individual error handler
        end)
    end
end

Alles anzeigen

There were some mistakes in my own code. But the decisive one was proposal.old2new. The proposal entities start at 0! Who could know this?! And also the syntax is different from what UG has written in the wiki. And I had to guess where to get the params from: There are several possibilities, but some of them are wrong. I think the official documentation is a little poor.

But just having finished this, I face a new problem: If you have got constructions with edges and nodes, the nodes will be cut. There is no more connection with the neighboring edges. This happens only with constructions with rigid edges, not with normal edges. So I'm looking for the cause, but I have no idea. Remove and insert the edges without their constructions is no good idea - it will crash the mod.

Now I am searching for a structure which describes the connections between neighboring edges and a mechanism to reconnect them. Any idea?

If you ask me why I need so difficult things: My project is to replace objects by themselves to update e.g. track styles. If you install a new track/street or track/street modifying mod, you normally don't have any chance to update already laid tracks/streets. So you have to replace them manually. I want to create a mod which does this work for me. But you also can imagine other applications. You could create tools to cut - copy - paste streets, tracks end even whole cities - or repair maps which you have created with no more available mods.

Alles anzeigen

I think the decisive one is api.type.SimpleProposal.ConstructionEntity.new(), since in last week replay you showed you constructed a construction proposal in lua, and the transf required in fact is a POD array, you would never get it work. Also the way you assign the playerId was not correct, but it should not be blocking since that just blocks you from editing a construction

for nodes thing, if in construction node is marked as snapNodes it should catch the neighboring edges (at least it works for game.interface.buildConstruction and game.interface.upgradeConstruction), if you try to modify edges in a construction via api, it will crash (sometimes when your cursors points at it). Normally you should not touche edges in a construction

The notion of connection is just node, if two edges share the same node they are connected if not they are not connected.

And I feel disapointed that you didn't do any comment on my last replay, since I took two hours last weekend to find you a working solution and summerize the essential part.

Doesn't track/street upgrading tool exist in vanilla game? of course you can replace street/tracks without a mod, why do you want to double the function? or you just don't know that exists already?

For constructions, the better api is the game.interface, it's also called by the modular system core code and missions so don't worry about if it will be removed one day.

Recently, I found this in Lollus Town Tuning Mod:

 local oldConstruction = game.interface.getEntity(oldConstructionId)
    local newId = game.interface.upgradeConstruction(
        oldConstruction.id,
        oldConstruction.fileName,
        -- leadingStation.params -- NO!
        arrayUtils.cloneOmittingFields(oldConstruction.params, {'seed'})
    )

Maybe seed must be omitted.

Clone shouldn't be needed, I would just try params.seed = nil

Zitat von WernerK

If I had game.interface as an alternative I would be happy. But I tested it once more. I am a simple thinker , so I thought that this would perhaps work:

Code

params = game.interface.getEntity(constrId).params
game.interface.upgradeConstruction(constrId, constr.fileName, params)

Ok, I didn't do this transf thing, but if the params are the same I think it has not to be done ...

I got this nice short error message :

Code

Error message: error: [string "C:/Program Files (x86)/Steam/userdata/1080598..."]:111: internal error
> Exception type: Fatal error
>
> Details:
>
> Error message: Assertion `pr.second' failed.
>
> Minidump: C:/Program Files (x86)/Steam/userdata/1080598009/1066780/local/crash_dump/0b551068-2454-41d3-ba96-640c5b00e92b.dmp
>
> In file: c:\build\tpf2_steam\src\lib\lua\value.cpp:38
>
> In function: class std::variant<struct lua::Nil,bool,double,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,struct lua::Table> &__cdecl lua::Table::Put(const class std::variant<struct lua::Nil,bool,double,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,struct lua::Table> &,class std::variant<struct lua::Nil,bool,double,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,struct lua::Table> &&)


stack traceback:
=[C](-1): ?
=[C](-1): upgradeConstruction
C:/Program Files (x86)/Steam/userdata/1080598009/1066780/local/mods/wk_entity_test_1/res/config/game_script/wk_entity_test.lua(111): ?

Alles anzeigen

I do not know what it means but I think I have inserted the wrong params.

But this is what drives me crazy - and this is the reason why I have almost given up this way.

Alles anzeigen

You need to remove seed from the params, for upgradeContrsuction and buildConstruction, i've been doing it since tpf1 and it works always like this

I don't know if params.seed = nil works sometimes you may get read only variables (not sure) so better to check it before use

the following code comes from my underground station:

local pure = function(pa)
    local params = {}
    for key, value in pairs(pa) do
        if (key ~= "seed") then
            params[key] = value
        end
    end
    return params
end

local script = {
    handleEvent = function(src, id, name, param)
        if (id == "__musEvent__") then
            if (name == "new") then
                local id = param.id
                local e = game.interface.getEntity(id)
                game.interface.upgradeConstruction(
                    id,
                    "station/rail/mus.con",
                    pure(e.params)
)
            end
        end
    end,
    guiHandleEvent = function(id, name, param)
        if name == "builder.apply" then
            local toAdd = param.proposal.toAdd
            if toAdd and #toAdd > 0 then
                for i = 1, #toAdd do
                    local con = toAdd[i]
                    if (con.fileName == [[station/rail/mus_cargo.con]]) then
                        if(con.params.isFinalized == 0) then
                            game.interface.sendScriptEvent("__musEvent__", "new", {id = param.result[1]})
                            game.interface.sendScriptEvent("__underpassEvent__", "new", {id = param.result[1], isStation = true})
                        end
                    end
                end
            end
        end
    end
}

function data()
    return script
end

Zitat

So I will go on with the other method and try to find out if and how I could reconnect the nodes. The question is if I am allowed to write directly into some param structures - and which. I think not ... my last chance is to find some examples elsewhere. Otherwise the changing of the constructions is not so important for the things I want to do.

You may keep the nodes from construction side and rebuild edges from free side and using the nodes from construction side so they should get connected.

Zitat

[OT] A very simple way to understand my project is to replace the vanilla track types by such with reduced top speed by a mod or a modifier. Now load an old map with already laid tracks. If you press [NUM]-[4] you will see that the top speed has not changed. . But if you lay new tracks, you get the right speed for them. So you would have to replace every single laid track by itself. For certain things (like streets with no developement) even the magic wand will not work! And this is exactly what I want to have automatized by a mod - but I cannot yet do it for stations, switch modules and so on ... I would be glad if I did not have to write such a difficult mod if the game would at least offer something like the F5-"update"-key in browsers or windows. If someone could tell me there is a hidden key I would be very happy because then I could program other much more exciting stuff.

More likely a bug of the game, have you reported to UG first?

Dont know in which thread you are, but upgradeConstruction is only available in Script Thread.

If seed is in params, I get pr.second' failed

If not, upgradeConstruction works for me, just tried it with an industry.

Now something with edges?

Road Depot? Has no params

What about "asset/wk_switch_kit_de_at.con"

p=game.interface.getEntity(5261).params
p.seed=irgendwasmitnil
p.wkskTrackDistFactor=2
game.interface.upgradeConstruction(5261,"asset/wk_switch_kit_de_at.con",p)

Now, it may be more complicated with connection nodes...