Is there a way to change a property of a CONSTRUCTION entity?

brunna · 12. Juli 2021

Hi!

I built a lot of houses with an old mod. Many houses have a huge personCapacity without cars.

I plan to run a script that reduces the personCapacity to 1 or 0 if the BASE_EDGE property is empty.

Is there a way to change the property of a CONSTRUCTION entity?

Thank you in advance for your answer!

VacuumTube · 12. Juli 2021

There is only getComponent, no set.

You need to upgrade the construction.

brunna · 12. Juli 2021

All right! And how can I upgrade? Is there an example of that?

Should I read the constructs to an array and update them in a cycle?

I can read the constructions. But I'm not sure how I can update them.

VacuumTube · 12. Juli 2021

With game.interface.upgradeConstruction

Maybe this helps: Update von Konstruktionen - SimpleProposal

brunna · 12. Juli 2021

Wow thank you! Very useful !!!

brunna · 12. Juli 2021

I tried but got an error.

Code

 >> building = game.interface.getEntity(415986)
 >> building
{
  baseEdges = { },
  baseNodes = { },
  dateBuilt = {
    day = 1,
    month = 1,
    year = 2021,
  },
  depots = { },
  fileName = "placeholders/generic.con",
  id = 415986,
  name = "no name",
  params = {
    assetBrush_brush = 1,
    assetBrush_rotation = 0,
    assetBrush_size = 0,
    assetBrush_slope = 0,
    assetBrush_slopeInvert = 0,
    assetBrush_strength = 19,
    assets = 0,
    bbhf_depot_1 = 0,
    building = 17,
    capacity = 5,
    paramX = 0,
    paramY = 0,
    randomize = 1,
    road = 0,
    seed = 273,
    skipcollision = 0,
    snowball_fences_adjust = 1,
    snowball_fences_collision = 0,
    snowball_fences_face = 0,
    snowball_fences_mode = 0,
    snowball_fences_offset = 0,
    street_connection = 0,
    terrainPainter_brush = 1,
    terrainPainter_rotation = 0,
    terrainPainter_size = 8,
    terrainPainter_slope = 0,
    terrainPainter_slopeInvert = 0,
    terrainPainter_strength = 19,
    terrain_brush = 1,
    terrain_rotation = 0,
    terrain_size = 31,
    terrain_strength = 19,
    ["tree/azalea.mdl"] = 1,
    ["tree/common_hazel.mdl"] = 1,
    ["tree/elderberry.mdl"] = 1,
    ["tree/european_linden.mdl"] = 1,
    ["tree/red_delicious_apple.mdl"] = 1,
    ["tree/scots_pine.mdl"] = 1,
    ["tree/shingle_oak.mdl"] = 1,
    ["tree/sugar_maple.mdl"] = 1,
    type = 1,
    year = 2021,
  },
  particleSystems = { 415987, },
  personCapacity = {
    capacity = 5,
    type = "RESIDENTIAL",
  },
  position = { 6945.9096679688, 5206.4521484375, 31.820449829102, },
  simBuildings = { },
  stations = { },
  townBuildings = { },
  transf = { 0.41147258877754, 0.91142213344574, 0, 0, -0.91142213344574, 0.41147258877754, 0, 0, 0, 0, 1, 0, 6945.9096679688, 5206.4521484375, 31.820449829102, 1, },
  type = "CONSTRUCTION",
}
>> game.interface.upgradeConstruction(building.id, building.fileName, building.params)
error: [string "game.interface.upgradeConstruction(building.i..."]:1: attempt to call field 'upgradeConstruction' (a nil value)
stack traceback:
    =[C](-1): upgradeConstruction
    game.interface.upgradeConstruction(building.id, building.fileName, building.params)(1): ?

Alles anzeigen

VacuumTube · 12. Juli 2021

Its part of the "old" api, where some parts are only available in script thread. Try with commonApi console

brunna · 13. Juli 2021

Thanks for the Tipp! Unfortunately I also get bugs with commonApi. Maybe later there will be an api update or a mod that will help me.

VacuumTube · 13. Juli 2021

There are some problems when you are in script thread. Try to pause the game when using.

**eis_os** · 13. Juli 2021

Only the script thread is allowed to modify the entity system and sendCommand (or better say, the Command will be later executed)

I cannot sync to UG lua threads, so it's a bit tricky for crowded lua threads

And if you don't report bugs, they won't be solved...

brunna · 13. Juli 2021

If I run this code in the Script Thread, I get the information about a construction.

Code

commonapi.dmp (game.interface.getEntity(8546))

If i run this than i don't get any error:

Code

local building = commonapi.dmp (game.interface.getEntity(8546))

But i can't read or print the "building" variable. I got this error when i try it:

Code

[string "building"]:1: syntax error near <eof>

I don't know that this varieble has values or not.

I tried this also but I got an error:

Code

commonapi.dmp (game.interface.upgradeConstruction(building.id, building.fileName, building.params))

Console::Execute: [string "commonapi.dmp (game.interface.upgradeConstruc..."]:1: attempt to index global 'building' (a nil value)

I don't know that how should i use the commonApi.

Could anyone write an example of a code that upgrades a construction? Please!

I think after that I can finished it.

**eis_os** · 13. Juli 2021

commonapi.dmp won't return anything, it dumps data, nothing more.

local building = game.interface.getEntity(8546)

commonapi.dmp(building)

local result = game.interface.upgradeConstruction(building.id, building.fileName, building.params)

commonapi.dmp(result)

Note: as the script thread is run a lot, a one liner is likely to have higher success rate:

local building = game.interface.getEntity(8546); game.interface.upgradeConstruction(building.id, building.fileName, building.params)

brunna · 13. Juli 2021

First of all thank you for your help!

I tried this in the commonApi Script Thread:

Code

local building = game.interface.getEntity(8546); game.interface.upgradeConstruction(building.id, building.fileName, building.params)

I got this:

Code

..\..\src\Lib\lua\Value.cpp:38: class std::variant<struct lua::Nil,bool,double,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,struct lua::Table> &__cdecl lua::Table::Put(const class std::variant<struct lua::Nil,bool,double,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,struct lua::Table> &,class std::variant<struct lua::Nil,bool,double,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,struct lua::Table> &&): Assertion `pr.second' failed.

Console::Execute: [string "local building = game.interface.getEntity(854..."]:1: internal error
> Exception type: Fatal error
> 
> Details:
> 
> Error message: Assertion `pr.second' failed.
> 
> Minidump: D:/Steam/userdata/189143849/1066780/local/crash_dump/e74c5161-d828-4fea-b0e2-d349b4cd7abf.dmp
> 
> In file: ..\..\src\Lib\lua\Value.cpp:38
> 
> In function: class std::variant<struct lua::Nil,bool,double,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,struct lua::Table> &__cdecl lua::Table::Put(const class std::variant<struct lua::Nil,bool,double,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,struct lua::Table> &,class std::variant<struct lua::Nil,bool,double,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,struct lua::Table> &&)


 >

Alles anzeigen

Second attempt:

Code

local building = game.interface.getEntity(8546); building.personCapacity = { }; game.interface.upgradeConstruction(building.id, building.fileName, building.params)

..\..\src\Lib\lua\Value.cpp:38: class std::variant<struct lua::Nil,bool,double,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,struct lua::Table> &__cdecl lua::Table::Put(const class std::variant<struct lua::Nil,bool,double,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,struct lua::Table> &,class std::variant<struct lua::Nil,bool,double,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,struct lua::Table> &&): Assertion `pr.second' failed.

Console::Execute: [string "local building = game.interface.getEntity(854..."]:1: internal error
> Exception type: Fatal error
> 
> Details:
> 
> Error message: Assertion `pr.second' failed.
> 
> Minidump: D:/Steam/userdata/189143849/1066780/local/crash_dump/edb17fcf-31a0-44ef-a1ae-849fe62cabe9.dmp
> 
> In file: ..\..\src\Lib\lua\Value.cpp:38
> 
> In function: class std::variant<struct lua::Nil,bool,double,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,struct lua::Table> &__cdecl lua::Table::Put(const class std::variant<struct lua::Nil,bool,double,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,struct lua::Table> &,class std::variant<struct lua::Nil,bool,double,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,struct lua::Table> &&)

Alles anzeigen

**eis_os** · 13. Juli 2021

Well it looks like some internal state broke, likely the upgradeConstruction doesn't like your params.

Sample, you aren't allowed to pass a seed in param.

Update von Konstruktionen - SimpleProposal

Please note: That isn't commonapi script thread, it's a TPF2 lua state.

That is the lua state used by all config/game_script/*.lua non ui related callbacks = Engine State described by UG

GUI Thread = GUI State as described by UG

There are two states created and handled by CommonAPI itself, the CommonAPI Main LUA => used by the CommonAPI UI Overlay

CommonAPI Game Env => used as bridge between UG and CommonAPI World, mostly unused

CommonAPI2 injects commands to the LUA States, but I have no control on them, so if it's running currently, it may crash badly or it's internal state goes out of control.

Yes, that it's not nice, and I know it should be better. But until the modding Update, neither TPF1 nor TPF2 had any access to a console at all.

VacuumTube · 13. Juli 2021

Dont use local in console

brunna · 14. Juli 2021

This code is the winner:

Code

local building = game.interface.getEntity(8546); building.params.seed = nil; game.interface.upgradeConstruction(building.id, building.fileName, building.params)

Thank you for your help!!

Is there a way to change a property of a CONSTRUCTION entity?

Willkommen in der Transport Fever Community

Teilen

Tags