Beiträge von CARTOK

Zitat von eis_os

TPF2 exe has this string:

Code

struct transport::Path __cdecl vehicle_util::common::`anonymous-namespace'::FindPathUnified<class vehicle_util::common::FindPathToDepot::<lambda_2db12c1f012abbc47ef40621f9a91d50>>(const struct vehicle_util::MovePathUtilContext &,class std::bitset<16>,const class std::vector<struct std::pair<struct transport::EdgeId,bool>,class std::allocator<struct std::pair<struct transport::EdgeId,bool> > > &,class vehicle_util::common::FindPathToDepot::<lambda_2db12c1f012abbc47ef40621f9a91d50>,float *)

This function is fired by the command processor, the one processing sendCommands -> sendToDepot

vehicle_util::MovePathUtilContext = Storage to pointers to all systems and ressources

class std::bitset<16> = Transport Modes

So the find depot is not very likely to be accessible by any api system functionality.

The transport vehicle depot id is only valid when the vehicle is heading to a depot. (and the flag sellOnArrival)

Alles anzeigen

Thank you! I suspected as much.

The only way via script would be to manually try to find all possible paths to determine if there is an appropriate depot (and also find the best one). Unfortunately, above my skill level. And also not sure if it's worth the effort.

I'm working around it by sending an existing vehicle to depot and looking for success, then capture that depot id. It's working, but causes the vehicle to be emptied, which can/does have a bad impact on profitability.

In an updated version of my script I'm caching the depot id (and stop id) to save on this, but this also requires some error checking code to see if it works i.e. the depot still exists, and is viable - if the vehicle remains in depot after sending to a line, that's an indication that the depot is no good for a line, and I can then re-check (by sending an existing vehicle to depot) for a new depot.

I've managed to send a request to UrbanGames (got a response!) to expand the API to avail some function to ease the depot-finding, or at least expose the clone vehicle function (which would be sufficient for my use case, "api.cmd.makeCloneVehicle" as an example). Let's see how that goes, I gather they are very busy with the upcoming update, not to mention the likely massive trove of other requests...

Zitat von VacuumTube

Tips:

Use pcall only when not possible otherwise. (If it fails because of the entity; there is an api function entityExists)

Already a few ms may affect sim performance if you are at the border of performance limit, as there are only 200ms for each step.

Test it with a large map.

You can use my timer.lua for measuring: https://github.com/Vacuum-Tube…atistics/script/timer.lua

Alles anzeigen

Thank you! I've tested quite a bit and run at about 6-8 ms per step, so I'm well within margin. The first steps fetches the a Cargo2Entity map which takes about 30ms, but that's essentially all that is done in that step. The remaining workload I'm spreading out over several ticks, carefully limiting the amount of work done within each tick. There's a bit of overhead associated with this, but not a problem.

Zitat von VacuumTube

I think the vehicles or lines should have a "depot" property somewhere, which is used for the default depot when cloning

Trying to find a solution to this as time permits, can confirm that this is not correct. When "cloning" a vehicle, it finds an appropriate depot at the time. This can be tested by creating a line with a distant depot, then adding a closer depot and selecting clone on the line vehicle (it will use the new and better placed depot).

Appreciate any suggestions on how to work on this. Looks like manual path testing is the only solution...

Edit: Looked at the source of AutoSig2, it is way over my skill level to interpret it unfortunately. But I gather it goes to show that there should be a solution in here somewhere to manually locate an appropriate depot without relying on workarounds. Ideally, however, there would simply be a "clone" api function exposed that would handle it.

Zitat von VacuumTube

game.interface.getEntity from a STATION_GROUP will give you "cargoWaiting" - which is used e.g. in ADvanced Statistics

Thanks!

I ended up using api_helper.getSimPersonsForLine(line_id) and api_helper.getSimCargosForLine(line_id), and then scan through all the entities with api.engine.getComponent(entity_id, api.type.ComponentType.SIM_ENTITY_AT_TERMINAL). Turns out that this is a pretty fast process and you can fetch hundreds of these within milliseconds.

Actual code below:

---@return table : details of the entity at terminal
function api_helper.getEntityAtTerminal(entity_id)
    local success, res = pcall(function()
        return api.engine.getComponent(entity_id, api.type.ComponentType.SIM_ENTITY_AT_TERMINAL)
    end)
    if success then
        return res
    else
        return nil
    end
end

---this functions samples the waiting cargo for each line and adds the information to the sampled line data
local function sampleWaitingCargo()
    log.debug("sampling: sampleWaitingCargo() starting")
    local finished = true
    local stopProcessing = false
    local processed_lines = 0
    local processed_items = 0

    for line_id, line_data in pairs(sampledLineData) do
        -- Check for marker
        if line_data.SAMPLE_WAITING_CARGO then
            local lineWaiting = 0
            local lineWaitingPeak = 0
            local stopsWithWaiting = 0
            local waitingEntitiesPerStop = {}
            local lineEntities = {}

            -- Start by setting the lineEntities as per already cached data
            if line_data.type == "PASSENGER" and lineSimPersonCache[line_id] then
                lineEntities = lineSimPersonCache[line_id]
            elseif line_data.type == "CARGO" and lineSimCargoCache[line_id] then
                lineEntities = lineSimCargoCache[line_id]
            end

            if #lineEntities > 0 then
                for _, value in pairs(lineEntities) do
                    local currentEntityId = value

                    -- Get the SIM_ENTITY_AT_TERMINAL unless already cached
                    if not simEntityAtTerminalCache[currentEntityId] then
                        local entity_at_terminal = api_helper.getEntityAtTerminal(currentEntityId)
                        if entity_at_terminal ~= nil then
                            simEntityAtTerminalCache[currentEntityId] = entity_at_terminal
                        else
                            simEntityAtTerminalCache[currentEntityId] = NO_ENTITY -- Set a value in case the entity is not at terminal (nil returned)
                        end

                        -- Check if we've processed too many items, then stop and restart next tick
                        processed_items = processed_items + 1
                        if processed_items >= MAX_ENTITIES_TO_PROCESS_PER_RUN then
                            finished = false
                            stopProcessing = true
                            log.debug("sampling: sampleWaitingCargo() processing limit reached, stopping")
                            break
                        end
                    end

                    -- Process the entity for the line, if it exists in the cache
                    if simEntityAtTerminalCache[currentEntityId] and simEntityAtTerminalCache[currentEntityId] ~= NO_ENTITY then
                        local currentEntity = simEntityAtTerminalCache[currentEntityId]

                        -- First check if the entity is waiting for this line, process it if so
                        if currentEntity.line == line_id then
                            -- If previous entry in the table created, then increase it, otherwise create and initialize it
                            if waitingEntitiesPerStop[currentEntity.lineStop0] then
                                waitingEntitiesPerStop[currentEntity.lineStop0] = waitingEntitiesPerStop[currentEntity.lineStop0] + 1
                            else
                                waitingEntitiesPerStop[currentEntity.lineStop0] = 1
                            end
                        end
                    end
                end

                -- If stop processing has been triggered, break this loop here
                if stopProcessing then
                    break
                end

                for _, value in pairs(waitingEntitiesPerStop) do
                    -- Count number of stops with anything waiting
                    if value > 0 then
                        stopsWithWaiting = stopsWithWaiting + 1
                    end

                    lineWaiting = lineWaiting + value
                    if value > lineWaitingPeak then
                        lineWaitingPeak = value
                    end
                end
            end

            -- Add sampled data to sampledLineData
            sampledLineData[line_id].waiting = lineWaiting
            sampledLineData[line_id].waiting_peak = lineWaitingPeak
            sampledLineData[line_id].stops_with_waiting = stopsWithWaiting

            -- Update markers
            sampledLineData[line_id].SAMPLE_WAITING_CARGO = nil
            sampledLineData[line_id].MERGE = true

            -- Update counters
            processed_lines = processed_lines + 1

            if processed_lines >= MAX_LINES_TO_PROCESS_PER_RUN then
                finished = false -- This state can't be completed (for sure) if we reached this, run it one more time
                log.debug("sampling: mergeLineData() processing limit reached, stopping")
                break
            end
        end
    end

    log.debug("sampling: sampleWaitingCargo() processed " .. processed_lines .. " lines and " .. processed_items .. " new items")
    return finished
end

Apologies, writing on phone as away from computer.

Looking for some guidance, or hint, for a sensible way to find the max CARGO or PASSENGER (SimEntities) waiting at any terminal used by line. This needs to be done for all lines.

A brute force way is to use getSimCargoForLine (and Person equivalent), and then cycle through them to fetch the SIM_CARGO_AT_TERMINAL (or ENTITY/PERSON) component.

This will however be rather inefficient as the same SimEntity will be applicable for many lines.

Is it possible to, for instance, cycle through each station (foreach), and then retrieve just the SimEntities waiting at that specific station?

The API reference is not particularly clear, and seems to be missing lots of existing functionality. Any assistance is appreciated!

Edit: I've noticed the following function exists:

getSimCargoAtTerminalForTransportNetwork(tnEntity)

Obtains all cargo that is waiting at the terminal.

Parameters:

tnEntity Entity the entity of the transport network

It is however unclear what tnEntity is in this instance, and how it is obtained. What constitutes an entity of the transport network? A station?

Hi all,

been here prior to look for some assistance as I've been digging away at my LineManager mod. Thanks to those who've assisted!

With that said, I've now (and finally) completed a major overhaul, and figured someone here may be interested. This mod allows the automatic addition/removal of vehicles from all types of lines; PASSENGER/CARGO (even MIXED, though not recommended), ROAD/TRAM/RAIL/WATER/AIR. Sensible pre-configured rules are used to achieve this, along with a decent attempt at balance the mod workload out over time to make performance impact unnoticable/minimal. It is relatively easy to amend/create your own rules that fit your own game better by digging into the source code.

Anyway, feel free to take a look at my GitHub repository for further information and source code: https://github.com/TommyC81/TPF2-LineManager

Zitat von VacuumTube

I think the vehicles or lines should have a "depot" property somewhere, which is used for the default depot when cloning

Located in the API reference now, the depot property is only applicable/valid when a vehicle is actually in the depot - it is not kept updated beyond that.

Thank you!

Yes, there is a depot property on each vehicle, this does however not seem to receive any updates as transport network changes. Perhaps what is done when cloning, it checks if it is still valid and if not another depot is found.

Is it possible to trigger a strict "clone" command via scripting?

Alternatively, if there's a good guide on how to interact with transport networks, stations, waiting cargo/passengers, nodes (and edges) etc. I could perhaps figure it out. I'm unfortunately at a loss at the moment.

For reference, sample of command and associated output:

>> api.engine.getComponent( 27602, api.type.ComponentType.TRANSPORT_VEHICLE )
{
  carrier = 2,
  transportVehicleConfig = {
    vehicles = {
      [1] = {
        part = {
          modelId = 3576,
          reversed = false,
          loadConfig = {
            [1] = 0,
          },
          color = {
            x = -1,
            y = -1,
            z = -1,
          },
          logo = "",
        },
        purchaseTime = 12417800,
        maintenanceState = 0,
        targetMaintenanceState = 0,
        autoLoadConfig = {
          [1] = 1,
        },
      },
    },
    vehicleGroups = {
      [1] = 1,
    },
  },
  config = {
    allCaps = { removed to simplify },
    capacities = { removed to simplify },
    loadSpeeds = { removed to simplify },
    reversible = false,
  },
  state = 1,
  userStopped = false,
  depot = 26683,
  sellOnArrival = false,
  line = 27606,
  stopIndex = 2,
  lineStopDepartures = {
    [1] = 128385000,
    [2] = 128428000,
    [3] = 128307800,
  },
  lastLineStopDeparture = 128261400,
  sectionTimes = {
    [1] = 38.400001525879,
    [2] = 42.000003814697,
    [3] = 72,
  },
  timeUntilLoad = -2.3969392776489,
  timeUntilCloseDoors = -0.067628532648087,
  timeUntilDeparture = -0.067628294229507,
  noPath = false,
  daysInDepot = 0,
  daysAtTerminal = 3,
  doorsOpen = false,
  doorsTime = 128426800000,
  autoDeparture = true,
}

Hi there, I've been creating a mod for automatic vehicle management on lines called "LineManager", GitHub link: https://github.com/TommyC81/TPF2-LineManager.

One item that is critical for this mod is of course the removal and addition of vehicles. Removal is easy using:

api.cmd.sendCommand(api.cmd.make.sellVehicle(vehicle_id))

However, for adding vehicles, you need to specify a depot. To find a depot I've made use of the following workaround, effectively (temporarily) sending an existing vehicle to depot to see if it can find one then cancel the depot call, but use the found depot_id. Like so:

for _, vehicle_id in pairs(lineVehicles) do
   api.cmd.sendCommand(api.cmd.make.sendToDepot(vehicle_id, false))
   vehicleToDuplicate = api.engine.getComponent(vehicle_id, api.type.ComponentType.TRANSPORT_VEHICLE)

   if vehicleToDuplicate.state == api.type.enum.TransportVehicleState.GOING_TO_DEPOT then
       depot_id = vehicleToDuplicate.depot
       stop_id = vehicleToDuplicate.stopIndex

       local lineCommand = api.cmd.make.setLine(vehicle_id, line_id, stop_id)
       api.cmd.sendCommand(lineCommand)
       break
   end
end

This unfortunately empties the vehicle sent to the depot, which is less than ideal.

Is there a better/sensible way to find a suitable (and accessible) depot for a specific line?

I've looked at the pathfinding functions (https://transportfever2.com/wi…util.pathfinding.findPath), and believe the answer might exist in that functionality. However, this is currently beyond my knowledge and skill to implement (in particular as the associated documentation is virtually non-existent).

Any suggestions or advice is appreciated, many thanks in advance!

Thanks for this report! And special thanks to VacuumTube for opening the issue, and provided some insights. I should be able to fix this shortly.

In the meanwhile, you may proceed to delete the sav.lua file or amend the entry as suggested by VacuumTube. There is no important state being saved at the moment.